Skip to content

safe to create ByteString from array with no-copy #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

safe to create ByteString from array with no-copy #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ad2da5
safe to create ByteString from array with no-copy
pjfanning Oct 3, 2025
092a279
another place where we know that the array is private in scope
pjfanning Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion http-core/src/main/scala/org/apache/pekko/http/impl/engine/ws/FrameEventRenderer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,6 @@ private[http] final class FrameEventRenderer extends GraphStage[FlowShape[FrameE
data(maskOffset + 3) = ((mask & 0x000000FF) >> 0).toByte
}

ByteString(data)
ByteString.fromArrayUnsafe(data)
}
}
2 changes: 1 addition & 1 deletion ...main/scala/org/apache/pekko/http/scaladsl/marshalling/PredefinedToEntityMarshallers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ trait PredefinedToEntityMarshallers extends MultipartMarshallers {
val byteBuffer = contentType.charset.nioCharset.encode(charBuffer)
val array = new Array[Byte](byteBuffer.remaining())
byteBuffer.get(array)
HttpEntity(contentType, array)
HttpEntity(contentType, ByteString.fromArrayUnsafe(array))
} else HttpEntity.Empty

implicit val DoneMarshaller: ToEntityMarshaller[pekko.Done] =
Expand Down
Loading