HDDS-14418. Skip sending block deletion command to SCM for empty files. #9635
+62
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@priyeshkaratha , can you add a unit test for this case? Manual test is good, but unit test is more preferred if not too difficult to create a new unit test. |
| keyBlocksList.size(), logSize, keyBlocksList.entrySet().stream().limit(logSize) | ||
| LOG.info("Send {} key(s) to SCM (filtered {} empty files), first {} keys: {}", | ||
| nonEmptyKeyBlocksList.size(), keyBlocksList.size() - nonEmptyKeyBlocksList.size(), logSize, | ||
| nonEmptyKeyBlocksList.entrySet().stream().limit(logSize) |
Contributor
There was a problem hiding this comment.
These empty files can happen mostly in testing, No need to update normal logs to avoid confusion. Instead please add separate debug log if any empty files/blocks are present.
Contributor
There was a problem hiding this comment.
+1. Lets keep them logged as DEBUG. Also probably use 'keys' instead of 'files' to maintain uniformity while logging
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing the changes. Addressed the changes mentioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When OM sends block deletion requests to SCM we can skip it if deleted blocklists are empty for the blockgroup. It indicates its delete request for empty file. So that we can also make sure fast deletion for keys that created with empty sizes.
What is the link to the Apache JIRA
HDDS-14418
How was this patch tested?
Tested locally using creating 1 empty file and 1 normal file and deleted both files. 1 file git skipped as per requirement.
CI is green