-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-14416. Handle delete ratis replica in DELETED/DELETING container scenario. #9630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@ashishkumar50 thanks for the patch! |
|
It seems the three test methods (testDeletedContainerWithStaleClosedReplicaRatis, testDeletedContainerWithLowerBcsidStaleReplicaRatis, and testDeletedECContainerWithStaleClosedReplicaShouldNotForceDelete) share duplicated code for creating ContainerReportHandler, building ContainerReportsProto, sending messages via reportHandler.onMessage(), and verifying DeleteContainerCommand. Could we try to extract a helper method like sendReportAndVerifyDeleteCommand() or something that handles the common setup and verification logic? |
priyeshkaratha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashishkumar50 for working on this. Changes LGTM
Extracted common code. |
|
@ashishkr200 thanks for the update! |
|
@errose28 @sumitagrawl, Can you please help to review this PR. |
What changes were proposed in this pull request?
When container state is DELETED/DELETING in SCM, and if any DN reports replica which is CLOSED and non-empty. And if replica bcs-id is less or equal to container sequence id, in this case SCM should trigger delete replica to DN. This will reduce orphan containers in the cluster.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14416
How was this patch tested?
Unit tests