HDDS-14416. Handle delete ratis replica in DELETED container scenario. #9630
+316
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishkumar50
requested review from
errose28,
siddhantsangwan and
sumitagrawl
Contributor
|
@ashishkumar50 thanks for the patch! |
Contributor
|
It seems the three test methods (testDeletedContainerWithStaleClosedReplicaRatis, testDeletedContainerWithLowerBcsidStaleReplicaRatis, and testDeletedECContainerWithStaleClosedReplicaShouldNotForceDelete) share duplicated code for creating ContainerReportHandler, building ContainerReportsProto, sending messages via reportHandler.onMessage(), and verifying DeleteContainerCommand. Could we try to extract a helper method like sendReportAndVerifyDeleteCommand() or something that handles the common setup and verification logic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When container state is DELETED in SCM, and if any DN reports replica which is CLOSED and non-empty. And if replica bcs-id is less or equal to container sequence id, in this case SCM should trigger delete replica to DN. This will reduce orphan containers in the cluster.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14416
How was this patch tested?
Unit tests