HDDS-14210. TestOmDBInsightEndPoint may fail. #9629
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
requested changes
Jan 13, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ArafatKhan2198 for working on this. If it's a test problem, please fix it in the test. We should not ignore closed database globally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The test testKeyCountsForValidAndInvalidKeyPrefix sometimes fails with "Rocks Database is closed" when trying to clear a database table.
Why it happens:
The test creates a new database before each test run.
It immediately tries to clear a table.
Sometimes the database isn’t fully ready yet, or it gets closed during setup.
The code that clears the table doesn’t handle a closed database, so it crashes.
The fix:
Updated the clear-table code to detect a closed database.
If the database is closed, log a warning and skip clearing (instead of crashing).
Still throw other errors so real problems aren’t hidden.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14210
How was this patch tested?