Skip to content

HDDS-14370. RandomAccessFileChannel to implement Closeable #9628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rich7420 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

HDDS-14370. RandomAccessFileChannel to implement Closeable #9628

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
855b74a
RandomAccessFileChannel to implement Closeable
rich7420 Jan 12, 2026
72a9027
fix pmd error
rich7420 Jan 13, 2026
fdaef5a
update
rich7420 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...op-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/io/RandomAccessFileChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.hadoop.hdds.utils.io;

import java.io.Closeable;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
Expand All @@ -29,7 +30,7 @@
import org.slf4j.LoggerFactory;

/** {@link RandomAccessFile} and its {@link FileChannel}. */
public class RandomAccessFileChannel {
public class RandomAccessFileChannel implements Closeable {
private static final Logger LOG = LoggerFactory.getLogger(RandomAccessFileChannel.class);

private File blockFile;
Expand Down Expand Up @@ -86,6 +87,7 @@ public synchronized boolean read(ByteBuffer buffer) throws IOException {
* In case of exception, this method catches the exception, logs a warning message,
* and then continue closing the remaining resources.
*/
@Override
public synchronized void close() {
if (blockFile == null) {
return;
Expand Down
Loading