Skip to content

Conversation

@Russole
Copy link
Contributor

@Russole Russole commented Jan 10, 2026

What changes were proposed in this pull request?

  • Fixed the default value of net.topology.node.switch.mapping.impl in ozone-default.xml
  • Updated the default to org.apache.hadoop.net.TableMapping to match the actual behavior of OM and SCM

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14385

How was this patch tested?

All CI checks passed.
https://github.com/Russole/ozone/actions/runs/20881195253

Copy link
Contributor

@sreejasahithi sreejasahithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Russole for fixing this,
LGTM

Copy link
Contributor

@sarvekshayr sarvekshayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Russole for the fix.

The description is about invoking a script, which is specific to ScriptBasedMapping, not TableMapping.

@sreejasahithi
Copy link
Contributor

Thanks @sarvekshayr for identifying the description mismatch , @Russole please update the description.

@jojochuang jojochuang self-requested a review January 12, 2026 17:21
@Russole
Copy link
Contributor Author

Russole commented Jan 12, 2026

Thanks @sreejasahithi and @sarvekshayr for the review. I’ve updated the patch based on the comments.

@jojochuang
Copy link
Contributor

actually according to https://issues.apache.org/jira/browse/HDDS-14385

The ScriptBasedMapping is used by default for node network location resolve.

@Russole
Copy link
Contributor Author

Russole commented Jan 15, 2026

Thanks @jojochuang for pointing this out.
Based on the discussion so far, it seems that this PR may no longer be necessary.
Please let me know if this PR is still required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants