HDDS-14364. [STS] Revoked permanent credential must render all associated STS tokens useless #9602
+148
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenSammi
reviewed
Jan 13, 2026
| private static boolean isOriginalAccessKeyIdRevoked(STSTokenIdentifier stsTokenIdentifier, OzoneManager ozoneManager) | ||
| throws OMException { | ||
| final String originalAccessKeyId = stsTokenIdentifier.getOriginalAccessKeyId(); | ||
| if (originalAccessKeyId == null) { |
Contributor
There was a problem hiding this comment.
originalAccessKeyId is already checked in ensureEssentialFieldsArePresentInToken(). Rest looks good to me.
ChenSammi
approved these changes
Jan 16, 2026
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
Thanks @fmorg-git . Wait for CI to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14364
How was this patch tested?
unit tests (and a prototype in a separate local branch)