feat(core): Add is_current to metadata #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 39bb79d)
Xuanwo
reviewed
Jan 2, 2025
|
I’ve updated the code based on your comments. PTAL, thanks! |
Xuanwo
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5474
Rationale for this change
Metadatanow containsversionfor the given file, but there is no way for users to different if this version the latest version of file.What changes are included in this PR?
add
is_currentfield to metadata and initialize it in s3 and oss serviceAre there any user-facing changes?
Add
Metadata::is_current() -> Option<bool>API for user.