feat(ovfs): add readme and user configuration #4686
Conversation
| /// format: <scheme>://?<key>=<value>&<key>=<value> | ||
| /// example: fs://?root=/tmp | ||
| #[arg(env = "OVFS_BACKEND", index = 2)] | ||
| backend: Url, |
There was a problem hiding this comment.
I don't like the idea of introducing a URL here. How about just using a HashMap? Our command line coule be like:
ovfs path/to/mount --scheme=s3 --access-key-id=xxx --secret-access-key=yyy --root=/tmpReading OVFS_BACKEND also doesn't make sense to me. We can start by accepting a simple map.
There was a problem hiding this comment.
This is ok for me, but I will have a concern about the alignment with ofs. I think ofs and ovfs should be used in a similar way. The usage here refers to the current implementation of ofs.
There was a problem hiding this comment.
I will initiate another discussion with ofs. However, I believe ovfs is a separate project that shouldn't adhere to the same design as ofs, especially when that design seems flawed.
There was a problem hiding this comment.
I feel that we're currently pushing too aggressively to release the binary to users. Instead, we should focus on developing a library, ensuring it functions correctly and passes the tests before making it available to users.
For example, we don't need to play with the config/command line/args right now. We should make it work and than design our user interface.
There was a problem hiding this comment.
Got this. I'll draft this PR first. We should reopen this PR to discuss the user interface of the binary after the ovfs library is fully developed.
No description provided.