Service: adding ocios support #4189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently support get, list Signed-off-by: Wei Zhang <[email protected]>
Xuanwo
reviewed
Feb 22, 2024
| @@ -249,6 +251,8 @@ impl Scheme { | |||
| Scheme::Postgresql, | |||
| #[cfg(feature = "services-gdrive")] | |||
| Scheme::Gdrive, | |||
| #[cfg(feature = "services-ocios")] | |||
| Scheme::OciOs, | |||
There was a problem hiding this comment.
Please use Ocios instead. We following the same pattern across the whole project:
Ocios->ociosOciOs->oci_os
|
|
||
| let loader = OCILoader::default(); | ||
|
|
||
| let signer = OCIAPIKeySigner::default(); |
There was a problem hiding this comment.
Will we have different signer from oci?
| })? | ||
| }; | ||
|
|
||
| let loader = OCILoader::default(); |
There was a problem hiding this comment.
Please use OciLoader instead. Maybe need changes from reqsign.
| /// Oracle Cloud Infrastructure Object Storage support | ||
| #[doc = include_str!("docs.md")] | ||
| #[derive(Default)] | ||
| pub struct OciOsBuilder { |
| read_with_if_match: true, | ||
| read_with_if_none_match: true, | ||
|
|
||
| write: false, |
| if let Some(cred) = cred { | ||
| Ok(Some(cred)) | ||
| } else { | ||
| // Mark this error as temporary since it could be caused by Aliyun STS. |
| ) -> Result<Request<AsyncBody>> { | ||
| let p = build_abs_path(&self.root, path); | ||
| let url = format!( | ||
| "objectstorage.{}.oraclecloud.com/n/{}/b/{}/o/{}", |
There was a problem hiding this comment.
url without protocol could be wrong.
| let p = build_abs_path(&self.root, path); | ||
| let url = format!( | ||
| "objectstorage.{}.oraclecloud.com/n/{}/b/{}/o", | ||
| self.region, self.namespace, self.bucket, |
There was a problem hiding this comment.
If the endpoint is always the same for all API, we can build this endpoint during build.
|
|
||
| // Add query arguments to the URL based on response overrides | ||
| let mut query_args = Vec::new(); | ||
| query_args.push(format!("{}={}", constants::QUERY_LIST_PREFIXY, p,)); |
| let bs = bytes::Bytes::from( | ||
| r#" | ||
| <?xml version="1.0" ?> | ||
| <Error xmlns="http://doc.oss-cn-hangzhou.aliyuncs.com"> |
ClSlaid
reviewed
Apr 11, 2024
| @@ -279,7 +285,7 @@ sha1 = { version = "0.10.6", optional = true } | |||
| sha2 = { version = "0.10", optional = true } | |||
|
|
|||
| # For http based services. | |||
| reqsign = { version = "0.14.7", default-features = false, optional = true } | |||
There was a problem hiding this comment.
Pin it to a commit should be better?
There was a problem hiding this comment.
We will continue after reqsign making a new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently support get, list