sim: fix regression from https://github.com/apache/nuttx/pull/14623 #15586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: work_timer_expiry may be called in thread context Signed-off-by: hujun5 <[email protected]>
1 task
github-actions
bot
added
Area: OS Components
1 task
xiaoxiang781216
approved these changes
Jan 17, 2025
yamt
reviewed
Jan 17, 2025
| @@ -80,6 +79,7 @@ static void work_timer_expiry(wdparm_t arg) | |||
| } | |||
|
|
|||
| spin_unlock_irqrestore(&work->wq->lock, flags); | |||
| sched_unlock(); | |||
There was a problem hiding this comment.
do these locks need to be released in this order for some reasons?
otherwise, it's more natural to release them in the reverse order of acquiring them.
There was a problem hiding this comment.
yes, it need be this order. but all shced_lock like thsi will be removed after #14578 get merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sim: fix regression from #14623
reason:
work_timer_expiry may be called in thread context
Impact
sim
Testing
#15582