Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/armv7-r: fix gic.h build error #15585

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

yf13
Copy link
Contributor

@yf13 yf13 commented Jan 17, 2025

Summary

This fixes compilation error:

/tmp/nuttx/arch/arm/src/armv7-r/gic.h:699:17: error: 'GIC_ICDSGIR_NSATT_GRP1' undeclared (first use in this function); did you mean 'GIC_ICDSGIR_NSATT'?

Impacts

Allow armv7-r code to build

Testing

  • local check when adding armv7-r support.
  • CI checks

This fixes compilation error:

```
/tmp/nuttx/arch/arm/src/armv7-r/gic.h:699:17: error:
'GIC_ICDSGIR_NSATT_GRP1' undeclared; did you mean 'GIC_ICDSGIR_NSATT'?
```

Signed-off-by: Yanfeng Liu <[email protected]>
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Size: XS The size of the change in this PR is very small labels Jan 17, 2025
@yf13
Copy link
Contributor Author

yf13 commented Jan 17, 2025

should we sync the macro definition with armv7-a instead?

@xiaoxiang781216, given that I am still new with armv7-a, to quickly check whether cortex-r5 works, maybe we can do minimum changes for now and reduce the differences later?

@xiaoxiang781216
Copy link
Contributor

should we sync the macro definition with armv7-a instead?

@xiaoxiang781216, given that I am still new with armv7-a, to quickly check whether cortex-r5 works, maybe we can do minimum changes for now and reduce the differences later?

OK

@xiaoxiang781216 xiaoxiang781216 merged commit 1bfff5a into apache:master Jan 17, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants