Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rp23xx_irq.c: fix regression from https://github.com/apache/nuttx/pull/15073 #15505

Closed
wants to merge 1 commit into from

Conversation

hujun260
Copy link
Contributor

Summary

fix regression from #15073

Impact

arch/arm/src/rp23xx/rp23xx_irq.c

Testing

ci #15503

@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small labels Jan 13, 2025
@nuttxpr
Copy link

nuttxpr commented Jan 13, 2025

[Experimental Bot, please feedback here]

No. This PR description lacks crucial information required by the NuttX guidelines.

Here's what's missing:

  • Summary: While it links a prior PR, it doesn't explain what the regression is. What functionality was broken? How does this PR fix it? What part of the code was changed and how?
  • Impact: The current entry just lists a file path. It needs to explicitly answer all the impact questions (user impact, build impact, hardware impact, documentation, security, compatibility). Use "NO" or "YES" followed by a description if yes.
  • Testing: Linking to a CI issue isn't sufficient. It needs to specify the local test setup used (host OS, compiler, target architecture and board) and provide actual before/after testing logs demonstrating the fix. Simply pointing to a CI run doesn't show what specific tests were run locally and their results.

The author needs to substantially expand this PR description to be accepted.

@hujun260 hujun260 closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants