Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Increase CI Jobs to 100% for Complex PRs #15460

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Jan 8, 2025

Summary

This PR increases the CI Jobs for Complex PRs from 50% to 100%, as explained here:

Impact

By increasing the CI Checks, we will have better quality PRs that won't fail the Daily Builds.

Complex PRs will now complete CI Checks in 2 hours 10 mins. (Instead of 1.5 hours previously)

No impact on Simple PRs that affect only One Single Architecture (arm32, risc-v, etc).

Testing

Complex PRs will now execute 100% of CI Jobs:

Simple PRs (Arm32) are not affected:

This PR increases the CI Jobs for Complex PRs from 50% to 100%, as explained here:
- apache#15451 (comment)
@github-actions github-actions bot added Area: CI Size: S The size of the change in this PR is small labels Jan 8, 2025
@nuttxpr
Copy link

nuttxpr commented Jan 8, 2025

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the NuttX requirements. The summary clearly explains the "why" and the "how" of the change, referencing the relevant issue. The impact section details the effects on build time (increased for complex PRs) and clarifies the lack of impact on simple PRs. The testing section provides links to CI runs demonstrating the change's behavior, effectively covering both complex and simple PR scenarios. While it doesn't include "before/after" logs in the specific format requested, the links to CI runs serve the same purpose, showing the results of the change in a verifiable way. The impact on users, hardware, documentation, security, and compatibility are all implicitly or explicitly addressed as having no impact.

@xiaoxiang781216 xiaoxiang781216 merged commit cd83dc1 into apache:master Jan 8, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] at32f437-mini/systemview: builds fail with error: implicit declaration of function 'SEGGER_RTT_LOCK'
3 participants