Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/spi_slave: call SPIS_DEV_NOTIFY when rx or tx complete for all spi slave driver #14411

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

Donny9
Copy link
Contributor

@Donny9 Donny9 commented Oct 19, 2024

Summary

drivers/spi_slave: call SPIS_DEV_NOTIFY when rx or tx complete for all spi slave driver
This PR is related to issue:#14369

Impact

call notify interface to notify userspace when read or write block

Testing

local

@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Size: S The size of the change in this PR is small labels Oct 19, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 19, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Lacks a clear explanation of why the change is necessary. What problem does it solve?
    • Needs more detail on how the change works. "call notify interface" is too vague. Which interface? What data is passed?
  • Impact:
    • All "Impact" sections are incomplete. You need to answer YES/NO for each and provide descriptions for any "YES" answers.
    • For example:
      • "Is new feature added?" should be YES.
      • "Impact on user?" is likely YES, and you need to describe how the user would use this new notification feature.
      • "Impact on documentation?" is likely YES, as you'll need to document this new interface.
  • Testing:
    • "local" is insufficient. Provide specifics about your build host and target(s), including:
      • Build Host OS, CPU, Compiler version
      • Target architecture, board, configuration
    • Include actual testing logs before and after the change.

Recommendations:

  1. Expand the Summary: Clearly articulate the problem this PR solves and provide a detailed explanation of the implemented solution.
  2. Complete the Impact section: Address all points with YES/NO and provide thorough descriptions where necessary.
  3. Provide Detailed Testing Information: List the specific build hosts and targets used, and include actual testing logs demonstrating the change's behavior.

@xiaoxiang781216 xiaoxiang781216 linked an issue Oct 19, 2024 that may be closed by this pull request
1 task
@acassis acassis merged commit c4780f1 into apache:master Oct 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HELP] SPI Slave Driver - semaphore release in spi_slave_read
3 participants