apps/testing: Move sd_bench to apps/bechmarks#2977
Conversation
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
b7aa49c to
7bb1892
Compare
|
[Experimental Bot, please feedback here] This PR likely does NOT meet the NuttX requirements, despite claiming to pass CI. SummaryThe provided summary is insufficient. It lacks crucial information like: why the ImpactWhile "apps/testing reorg" hints at an impact on the apps, it doesn't adequately address the required details. The PR author needs to specify YES/NO for each impact category and provide descriptions where applicable. For example, even if user impact is NO, they should explicitly state NO. For a reorganization, documentation impact is likely YES, requiring explanation of the new structure. Build impact might also be YES if build scripts or dependencies changed. The current response ignores these details. Testing"pass ci" is inadequate. While CI passing is good, the requirement is to demonstrate local verification before submitting the PR. This means specifying the host and target environments and providing actual log output demonstrating the issue before the change and the successful operation after the change. Just stating "pass ci" avoids demonstrating personal due diligence and makes it difficult to understand what was actually tested. In short, this PR needs substantial improvement in providing the necessary information before it can be considered for merging. |
cederom
left a comment
There was a problem hiding this comment.
Thank you @xiaoxiang781216 :-)
Summary
Benchmark utils relocation from
apps/testingtoapps/benchmarksas discussed in #2931 and #2961.Impact
Benchmarks relocation (
apps/testing -> apps/benchmarks).Testing
pass ci