NIFI-15286 Verify nodes connect-ability in Kafka3ConnectionService #10596
+618
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not-authorized to describe the cluster, verify connect-ability to bootstrap servers.
exceptionfactory
requested changes
Dec 3, 2025
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for providing this improvement @dariuszseweryn. The general approach looks good. I noted some initial recommendations, and plan to take a closer look at some of the implementation details.
...hared/src/test/java/org/apache/nifi/kafka/service/verification/KafkaClusterVerifierTest.java
Outdated
Show resolved
Hide resolved
...ervice-shared/src/test/java/org/apache/nifi/kafka/service/Kafka3ConnectionServiceBaseIT.java
Outdated
Show resolved
Hide resolved
...hared/src/test/java/org/apache/nifi/kafka/service/verification/KafkaClusterVerifierTest.java
Outdated
Show resolved
Hide resolved
...ce-shared/src/main/java/org/apache/nifi/kafka/service/verification/KafkaClusterVerifier.java
Outdated
Show resolved
Hide resolved
...ce-shared/src/main/java/org/apache/nifi/kafka/service/verification/KafkaClusterVerifier.java
Outdated
Show resolved
Hide resolved
...ce-shared/src/main/java/org/apache/nifi/kafka/service/verification/KafkaClusterVerifier.java
Outdated
Show resolved
Hide resolved
...ce-shared/src/main/java/org/apache/nifi/kafka/service/verification/KafkaClusterVerifier.java
Outdated
Show resolved
Hide resolved
...i-kafka-service-shared/src/main/java/org/apache/nifi/kafka/service/KafkaClusterVerifier.java
Show resolved
Hide resolved
...hared/src/test/java/org/apache/nifi/kafka/service/verification/KafkaClusterVerifierTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not-authorized to describe the cluster, verify connect-ability to bootstrap servers.
Summary
NIFI-15286
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-15286NIFI-15286Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation