NIFI-11362 Stabilize TestValidateRecord#testValidateJsonTimestamp by reordering scenarios and resetting reader properties

[hwu2024]

Summary

NIFI-11362
This PR fixes a flaky test in TestValidateRecord#testValidateJsonTimestamp that fails under the NonDex plugin. The failure is caused by order‑dependent configuration in a single test method that reuses the same JsonTreeReader controller service across multiple scenarios. The change reorders the scenarios and explicitly resets the reader properties to remove hidden state coupling.

Problem

Running the test normally passes:

mvn -pl nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors \
    test -Dtest=org.apache.nifi.processors.standard.TestValidateRecord#testValidateJsonTimestamp

…but running with NonDex reveals a failure:

mvn -pl nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors \
    edu.illinois:nondex-maven-plugin:2.2.1:nondex \
    -Dtest=org.apache.nifi.processors.standard.TestValidateRecord#testValidateJsonTimestamp

Failure excerpt:

org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
    at org.apache.nifi.util.StandardProcessorTestRunner.assertTransferCount(StandardProcessorTestRunner.java:407)
    at org.apache.nifi.processors.standard.TestValidateRecord.testValidateJsonTimestamp(TestValidateRecord.java:580)

Root Cause

testValidateJsonTimestamp() executes three scenarios by reconfiguring the same JsonTreeReader and rerunning:

1. Valid JSON with explicit schema and yyyy/MM/dd HH:mm:ss

2. JSON with an invalid timestamp format (yyyy-MM-dd HH:mm:ss)

3. Inferred schema with yyyy/MM/dd HH:mm:ss

Because the same controller service instance is reused and reconfigured in‑place, internal state/configuration can leak across scenarios. The final scenario sometimes observes residual configuration from the previous one, leading to unexpected routing (e.g., REL_VALID count is 0 instead of 1).

What this PR changes

• Reorder scenarios so that the Inferred Schema scenario runs before the Invalid Format scenario.

• Reset the reader configuration back to schema-text-property and restore SCHEMA_TEXT before running the Invalid Format scenario.

• Preserve clearTransferState() calls and the disable/enable cycle to apply configuration changes deterministically.

This keeps the test’s intent/coverage the same while avoiding state leakage that NonDex can expose.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using ./mvnw clean install -P contrib-check
  • JDK 21
  • JDK 25

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files