NIFI-14999: Adding support to stop a starting processor. #10344
Merged
+683
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgilman
force-pushed
the
NIFI-14999
branch
from
28bcea3 to
2e6ecb3
Compare
mcgilman
force-pushed
the
NIFI-14999
branch
from
2e6ecb3 to
df72763
Compare
sfc-gh-mpayne
suggested changes
Oct 1, 2025
There was a problem hiding this comment.
Thanks @mcgilman the backend changes look good for the most part. Only real concern that I have is around handling NullPointerException explicitly
Comment on lines
571
to
572
| } catch (NullPointerException npe) { | ||
| throw new NiFiCoreException("Unable to stop starting processor.", npe); |
There was a problem hiding this comment.
We should not be catching NullPointers
| } catch (NullPointerException npe) { | ||
| throw new NiFiCoreException("Unable to stop starting processor.", npe); | ||
| } catch (Exception e) { | ||
| throw new NiFiCoreException("Unable to stop starting processor: " + e, e); |
There was a problem hiding this comment.
The Exception in this case should probably include the toString() of the Processor in question.
sfc-gh-mpayne
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for exposing the physical state of processors in the NiFi API, enabling the UI to allow stopping processors that are in the
STARTINGphysical state.Problem Statement
Previously, when a processor was starting up (executing
@OnScheduledmethods), its logical state wasSTOPPEDbut the physical state wasSTARTING. The UI had no visibility into this physical state. Users couldn't stop processors that were stuck in theSTARTINGstate, requiring process group-level stops as a workaroundSolution Overview
Added
physicalStatefield to processor DTOs and entities, with full support for:STARTINGprocessors