Skip to content

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Sep 18, 2025

Summary

NIFI-14968 - Add support for Bitbucket Data Center

Breaking Change - the API version property is removed and Registry Clients do not support the migrateProperties feature so there is no nice way to remove it. However I think this is OK and can be clearly identified in the release notes / migration notes. Happy to re-add the property if needed and just ignore it.

Important - for Data Center, when committing a file using multipart, the existing code was not working also sending data using curl was working as expected. It turned out that the multipart was not formatted properly and it was expecting the filename as part of the content disposition.

Also... as of September 9th, Bitbucket does not allow users to create App Passwords anymore and API Tokens are the long term replacement. I have made the changes to reflect this.

Most of the work is to decouple the Data Center 1.0 APIs and the Cloud 2.0 APIs. I also fixed an issue that existed in case the registry client is used against a repo that has just been created with no commit at all (quite rare but this is now supported).

The change has been tested against both a Cloud and a Data Center instance. For Data Center, I tested against the latest version Data Center 10.0.

Screenshot 2025-09-18 at 20 10 23 Screenshot 2025-09-18 at 20 10 59

All the usual scenarios have been tested: branching, change version, commit version, start version control, as well as some of the usual edge cases.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant