NIFI-14968 - Add support for Bitbucket Data Center #10322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14968 - Add support for Bitbucket Data Center
Breaking Change - the API version property is removed and Registry Clients do not support the migrateProperties feature so there is no nice way to remove it. However I think this is OK and can be clearly identified in the release notes / migration notes. Happy to re-add the property if needed and just ignore it.
Important - for Data Center, when committing a file using multipart, the existing code was not working also sending data using curl was working as expected. It turned out that the multipart was not formatted properly and it was expecting the filename as part of the content disposition.
Also... as of September 9th, Bitbucket does not allow users to create App Passwords anymore and API Tokens are the long term replacement. I have made the changes to reflect this.
Most of the work is to decouple the Data Center 1.0 APIs and the Cloud 2.0 APIs. I also fixed an issue that existed in case the registry client is used against a repo that has just been created with no commit at all (quite rare but this is now supported).
The change has been tested against both a Cloud and a Data Center instance. For Data Center, I tested against the latest version Data Center 10.0.
All the usual scenarios have been tested: branching, change version, commit version, start version control, as well as some of the usual edge cases.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation