NIFI-15039 Use List of Enum Values in InvokeHTTP and Elasticsearch Indexing (#10372)

- Optimization for iteration over all Enum values on every FlowFile processed

Signed-off-by: David Handermann <[email protected]>

Author: mosermw

nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service-api/src/main/java/org/apache/nifi/elasticsearch/IndexOperationRequest.java

@@ -17,7 +17,7 @@
 
 package org.apache.nifi.elasticsearch;
 
-import java.util.Arrays;
+import java.util.List;
 import java.util.Map;
 
 /**
@@ -93,6 +93,9 @@ public enum Operation {
         Index("index"),
         Update("update"),
         Upsert("upsert");
+
+        private static final List<Operation> VALUES = List.of(Operation.values());
+
         private final String value;
 
         Operation(final String value) {
@@ -104,9 +107,12 @@ public String getValue() {
         }
 
         public static Operation forValue(final String value) {
-            return Arrays.stream(Operation.values())
-                    .filter(o -> o.getValue().equalsIgnoreCase(value)).findFirst()
-                    .orElseThrow(() -> new IllegalArgumentException(String.format("Unknown Index Operation %s", value)));
+            for (final Operation operation : VALUES) {
+                if (operation.value.equalsIgnoreCase(value)) {
+                    return operation;
+                }
+            }
+            throw new IllegalArgumentException(String.format("Unknown Index Operation %s", value));
         }
     }
 

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java

@@ -175,6 +175,8 @@ public class InvokeHTTP extends AbstractProcessor {
     private static final Pattern FORM_DATA_NAME_PARAMETER_PATTERN = Pattern.compile("post:form:(?<formDataName>.*)$");
     private static final String FORM_DATA_NAME_GROUP = "formDataName";
 
+    private static final List<HttpMethod> HTTP_METHOD_VALUES = List.of(HttpMethod.values());
+
     private static final Set<String> IGNORED_REQUEST_ATTRIBUTES = Set.of(
             STATUS_CODE,
             STATUS_MESSAGE,
@@ -1319,7 +1321,7 @@ private String getFileNameFromUrl(URL url) {
     }
 
     private Optional<HttpMethod> findRequestMethod(String method) {
-        return Arrays.stream(HttpMethod.values())
+        return HTTP_METHOD_VALUES.stream()
                 .filter(httpMethod -> httpMethod.name().equals(method))
                 .findFirst();
     }