NIFI-15049 Adjusted ExecuteSQL to use static List of Descriptors and Set of Relationships (#10381)

Signed-off-by: David Handermann <[email protected]>

Author: dan-s1

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java

@@ -33,6 +33,7 @@
 import org.apache.nifi.flowfile.FlowFile;
 import org.apache.nifi.processor.ProcessContext;
 import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
 import org.apache.nifi.processor.util.StandardValidators;
 import org.apache.nifi.processors.standard.sql.DefaultAvroSqlWriter;
 import org.apache.nifi.processors.standard.sql.SqlWriter;
@@ -142,28 +143,32 @@ public class ExecuteSQL extends AbstractExecuteSQL {
             .required(true)
             .build();
 
+    private static final List<PropertyDescriptor> PROPERTY_DESCRIPTORS = List.of(
+            DBCP_SERVICE,
+            SQL_PRE_QUERY,
+            SQL_QUERY,
+            SQL_POST_QUERY,
+            QUERY_TIMEOUT,
+            NORMALIZE_NAMES_FOR_AVRO,
+            USE_AVRO_LOGICAL_TYPES,
+            COMPRESSION_FORMAT,
+            DEFAULT_PRECISION,
+            DEFAULT_SCALE,
+            MAX_ROWS_PER_FLOW_FILE,
+            OUTPUT_BATCH_SIZE,
+            FETCH_SIZE,
+            AUTO_COMMIT,
+            CONTENT_OUTPUT_STRATEGY
+    );
+
+    private static final Set<Relationship> RELATIONSHIPS = Set.of(
+            REL_SUCCESS,
+            REL_FAILURE
+    );
+
     public ExecuteSQL() {
-        relationships = Set.of(
-                REL_SUCCESS,
-                REL_FAILURE
-        );
-        propDescriptors = List.of(
-                DBCP_SERVICE,
-                SQL_PRE_QUERY,
-                SQL_QUERY,
-                SQL_POST_QUERY,
-                QUERY_TIMEOUT,
-                NORMALIZE_NAMES_FOR_AVRO,
-                USE_AVRO_LOGICAL_TYPES,
-                COMPRESSION_FORMAT,
-                DEFAULT_PRECISION,
-                DEFAULT_SCALE,
-                MAX_ROWS_PER_FLOW_FILE,
-                OUTPUT_BATCH_SIZE,
-                FETCH_SIZE,
-                AUTO_COMMIT,
-                CONTENT_OUTPUT_STRATEGY
-        );
+        relationships = RELATIONSHIPS;
+        propDescriptors = PROPERTY_DESCRIPTORS;
     }
 
     @Override