Skip to content

Parameter 'request' is never used #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Parameter 'request' is never used #2338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...ings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ public SettingsBuildingResult build(SettingsBuildingRequest request) throws Sett

Source globalSettingsSource =
getSettingsSource(request.getGlobalSettingsFile(), request.getGlobalSettingsSource());
Settings globalSettings = readSettings(globalSettingsSource, request, problems);
Settings globalSettings = readSettings(globalSettingsSource, problems);

Source userSettingsSource = getSettingsSource(request.getUserSettingsFile(), request.getUserSettingsSource());
Settings userSettings = readSettings(userSettingsSource, request, problems);
Settings userSettings = readSettings(userSettingsSource, problems);

settingsMerger.merge(userSettings, globalSettings, TrackableBase.GLOBAL_LEVEL);

Expand Down Expand Up @@ -140,8 +140,7 @@ private Source getSettingsSource(File settingsFile, Source settingsSource) {
return null;
}

private Settings readSettings(
Source settingsSource, SettingsBuildingRequest request, DefaultSettingsProblemCollector problems) {
private Settings readSettings(Source settingsSource, DefaultSettingsProblemCollector problems) {
if (settingsSource == null) {
return new Settings();
}
Expand Down