Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-8674] Deprecate mergeId in the Maven 3 model and remove it in the new model #2233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MNG-8674] Deprecate mergeId in the Maven 3 model and remove it in the new model #2233

wants to merge 1 commit into from

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Apr 4, 2025

JIRA issue: MNG-8674

@gnodet gnodet added this to the 4.0.0-rc-4 milestone Apr 4, 2025
elharo
elharo requested changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one confuses me.

api/maven-api-model/src/main/mdo/maven.mdo
<version>4.0.0+</version>
<code>
<![CDATA[
@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these are new methods being added in a deprecated state? That's unusual.

There should be a Javadoc comment about them of some kind, perhaps just indicating that they should not be used at all.

And if they're deprecated because they're only for internal use, that's not really what deprecated is typically used for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-rc-4
Development

Successfully merging this pull request may close these issues.
2 participants
@gnodet @elharo