[EXPERIMENT] Delegate to Resolver for Artifact ordering #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies MRESOLVER-390 changes, and removes all sprinkled artifact ordering, delegates fully to Resolver. --- https://issues.apache.org/jira/browse/MRESOLVER-390
cstamas
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
cstamas
added a commit
that referenced
this pull request
Dec 7, 2023
Remove all ordering from Maven and delegate it to Resolver. Supersedes #1212 This PR makes Maven completely rely on Resolver to order artifacts on classpath (before this PR it was several spots where explicit ordering was applied without ability to affect it). This PR makes now Maven completely rely on Resolver, never "sort" artifacts on it's own, but use resolver result, that in turn depends on session config. Example invocation: ``` $ mvn -X package -Daether.system.dependencyVisitor=levelOrder ``` Would make Maven use "levelOrder". Example of default (preOrder, as before) and new levelOlder (new in 2.0): notice how tree is same, but resulting artifact list (and hence, order on classpath) is different: https://gist.github.com/cstamas/c88ca550006e53edad5b16973b54c349 The new resolver configuration is documented here: https://maven.apache.org/resolver-archives/resolver-2.0.0-alpha-3/configuration.html (property No 62) --- https://issues.apache.org/jira/browse/MNG-7953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies MRESOLVER-390 changes, and removes all sprinkled artifact ordering, delegates fully to Resolver.
If you do
mvn -X packageyou can see for example that enforcer plugin classpath is built in pre-order way from tree:https://gist.github.com/cstamas/d1cb11d96938cdb9e6da2b46eec449b6
Now, if do
mvn -X package -Daether.system.resolveDependencies.visitor=levelOrder, then enforcer plugin classpath is built in level order:https://gist.github.com/cstamas/6498cfb31afe74ded1471c02d982eee6
Note: to build, needs apache/maven-resolver#322
https://issues.apache.org/jira/browse/MRESOLVER-390
also related https://issues.apache.org/jira/browse/MNG-6357