SWEEP: Make private/internal fields readonly where possible, #661 (#1103)

Author: paulirwin

src/Lucene.Net.Analysis.Common/Analysis/Br/BrazilianAnalyzer.cs

@@ -28,13 +28,13 @@ namespace Lucene.Net.Analysis.Br
      */
 
     /// <summary>
-    /// <see cref="Analyzer"/> for Brazilian Portuguese language. 
+    /// <see cref="Analyzer"/> for Brazilian Portuguese language.
     /// <para>
     /// Supports an external list of stopwords (words that
     /// will not be indexed at all) and an external list of exclusions (words that will
     /// not be stemmed, but indexed).
     /// </para>
-    /// 
+    ///
     /// <para><b>NOTE</b>: This class uses the same <see cref="LuceneVersion"/>
     /// dependent settings as <see cref="StandardAnalyzer"/>.</para>
     /// </summary>
@@ -77,7 +77,7 @@ private static CharArraySet LoadDefaultStopSet() // LUCENENET: Avoid static cons
         /// <summary>
         /// Contains words that should be indexed but not stemmed.
         /// </summary>
-        private CharArraySet excltable = CharArraySet.Empty;
+        private readonly CharArraySet excltable = CharArraySet.Empty; // LUCENENET: marked readonly
 
         /// <summary>
         /// Builds an analyzer with the default stop words (<see cref="DefaultStopSet"/>).
@@ -135,4 +135,4 @@ protected internal override TokenStreamComponents CreateComponents(string fieldN
             return new TokenStreamComponents(source, new BrazilianStemFilter(result));
         }
     }
-}
+}

src/Lucene.Net.Analysis.Common/Analysis/CharFilter/HTMLStripCharFilter.cs

@@ -30792,19 +30792,19 @@ CharArrayDictionary<char> result
         private static readonly char STYLE_REPLACEMENT = '\n';
         private static readonly char REPLACEMENT_CHARACTER = '\uFFFD';
 
-        private CharArraySet escapedTags = null;
+        private readonly CharArraySet escapedTags = null; // LUCENENET: marked readonly
         private int inputStart;
         private int cumulativeDiff;
-        private bool escapeBR = false;
-        private bool escapeSCRIPT = false;
-        private bool escapeSTYLE = false;
+        private readonly bool escapeBR = false; // LUCENENET: marked readonly
+        private readonly bool escapeSCRIPT = false; // LUCENENET: marked readonly
+        private readonly bool escapeSTYLE = false; // LUCENENET: marked readonly
         private int restoreState;
         private int previousRestoreState;
         private int outputCharCount;
         private int eofReturnValue;
-        private TextSegment inputSegment = new TextSegment(INITIAL_INPUT_SEGMENT_SIZE);
+        private readonly TextSegment inputSegment = new TextSegment(INITIAL_INPUT_SEGMENT_SIZE); // LUCENENET: marked readonly
         private TextSegment outputSegment;
-        private TextSegment entitySegment = new TextSegment(2);
+        private readonly TextSegment entitySegment = new TextSegment(2); // LUCENENET: marked readonly
 
         /// <summary>
         /// Creates a new HTMLStripCharFilter over the provided TextReader.