SWEEP: PrintStackTrace cleanup, #932 (#1101)

* SWEEP: Exception.StackTrace cleanup, #932

* Add unit tests for StackTraceHelper, #932

* Better assert for PrintCurrentStackTrace that caller is the top line

* PR feedback

* Add string.Contains extension method for .NET Framework and Standard 2.0

* Use MemoryExtensions.Contains

* Revert test code to use extension method

* Use is null

Author: paulirwin

Directory.Build.targets

@@ -80,7 +80,7 @@
     <DebugType>portable</DebugType>
   </PropertyGroup>
 
-  <!-- Features in .NET Standard 2.1, .NET 5.x, .NET 6.x, .NET 7.x, .NET 8.x, and .NET 9.x only -->
+  <!-- Features in .NET Standard 2.1, .NET Core 3.x, .NET 5.x, .NET 6.x, .NET 7.x, .NET 8.x, and .NET 9.x only -->
   <PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.1' Or $(TargetFramework.StartsWith('netcoreapp3.')) Or $(TargetFramework.StartsWith('net5.')) Or $(TargetFramework.StartsWith('net6.')) Or $(TargetFramework.StartsWith('net7.')) Or $(TargetFramework.StartsWith('net8.')) Or $(TargetFramework.StartsWith('net9.')) ">
 
     <DefineConstants>$(DefineConstants);FEATURE_ARRAY_FILL</DefineConstants>
@@ -93,6 +93,13 @@
 
   </PropertyGroup>
 
+  <!-- Features in .NET Standard 2.1, .NET Core 2.1-2.2, .NET Core 3.x, .NET 5.x, .NET 6.x, .NET 7.x, .NET 8.x, and .NET 9.x only -->
+  <PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.1' Or '$(TargetFramework)' == 'netcoreapp2.1' Or '$(TargetFramework)' == 'netcoreapp2.2' Or $(TargetFramework.StartsWith('netcoreapp3.')) Or $(TargetFramework.StartsWith('net5.')) Or $(TargetFramework.StartsWith('net6.')) Or $(TargetFramework.StartsWith('net7.')) Or $(TargetFramework.StartsWith('net8.')) Or $(TargetFramework.StartsWith('net9.')) ">
+
+    <DefineConstants>$(DefineConstants);FEATURE_STRING_CONTAINS_STRINGCOMPARISON</DefineConstants>
+
+  </PropertyGroup>
+
   <!-- Features in .NET Standard 2.x, .NET Core 2.x, .NET Core 3.x, .NET 5.x, .NET 6.x, .NET 7.x, .NET 8.x, and .NET 9.x -->
   <PropertyGroup Condition=" $(TargetFramework.StartsWith('netstandard2.')) Or $(TargetFramework.StartsWith('netcoreapp2.')) Or $(TargetFramework.StartsWith('netcoreapp3.')) Or $(TargetFramework.StartsWith('net5.')) Or $(TargetFramework.StartsWith('net6.')) Or $(TargetFramework.StartsWith('net7.')) Or $(TargetFramework.StartsWith('net8.')) Or $(TargetFramework.StartsWith('net9.')) ">
 

src/Lucene.Net.Benchmark/ByTask/Benchmark.cs

@@ -58,8 +58,7 @@ public Benchmark(TextReader algReader)
             }
             catch (Exception e) when (e.IsException())
             {
-                //e.printStackTrace();
-                Console.Error.WriteLine(e.ToString());
+                e.PrintStackTrace();
                 throw new Exception("Error: cannot init PerfRunData!", e);
             }
 
@@ -145,7 +144,7 @@ public static void Exec(string[] args)
             }
             catch (Exception e) when (e.IsException())
             {
-                Console.Error.WriteLine(e.ToString());
+                e.PrintStackTrace();
                 Environment.Exit(1);
             }
 
@@ -160,7 +159,7 @@ public static void Exec(string[] args)
             catch (Exception e) when (e.IsException())
             {
                 Console.Error.WriteLine("Error: cannot execute the algorithm! " + e.Message);
-                Console.Error.WriteLine(e.ToString());
+                e.PrintStackTrace();
             }
 
             Console.WriteLine("####################");