Consistent handling of HTTP/S proxy environment variables #2079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent handling of HTTP/S proxy environment variables
Description
This PR provides consistent handling of the
http_proxy,https_proxy, andno_proxyenvironment variables in line with the behavior of the Requests python library. Previouslyno_proxywasn't being respected (#2077).This is done by removing explicit handling of the
http_proxyandhttps_proxyenv variables in favor of downstream handling through the Requests library. Explicitly provided proxy settings through theproxy_urlargument to the connection class and through theset_http_proxymethod are still supported and still take precedence over the environment variables.Status
done, ready for review
Checklist (tick everything that applies)