Skip to content

MINOR: changed the condition to only check the test topic to reduce the flakiness of the test. #20664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
+4 −3
Merged

MINOR: changed the condition to only check the test topic to reduce the flakiness of the test. #20664

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a56a91e
MINOR: changed the condition to only check the test topic to reduce t…
Nikita-Shupletsov Oct 8, 2025
80c484e
Updated the error message.
Nikita-Shupletsov Oct 9, 2025
1e211ef
Small refactoring.
Nikita-Shupletsov Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tools/src/test/java/org/apache/kafka/tools/TopicCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,14 +1192,15 @@ public void testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress(Cl
// describe the topic and test if it's under-replicated
String simpleDescribeOutput = captureDescribeTopicStandardOut(clusterInstance, buildTopicCommandOptionsWithBootstrap(clusterInstance, "--describe", "--topic", testTopicName));
String[] simpleDescribeOutputRows = simpleDescribeOutput.split(System.lineSeparator());
assertTrue(simpleDescribeOutputRows[0].startsWith(String.format("Topic: %s", testTopicName)),
String testTopicNameLogLine = String.format("Topic: %s", testTopicName);
assertTrue(simpleDescribeOutputRows[0].startsWith(testTopicNameLogLine),
"Unexpected describe output: " + simpleDescribeOutputRows[0]);
assertEquals(2, simpleDescribeOutputRows.length,
"Unexpected describe output length: " + simpleDescribeOutputRows.length);

String underReplicatedOutput = captureDescribeTopicStandardOut(clusterInstance, buildTopicCommandOptionsWithBootstrap(clusterInstance, "--describe", "--under-replicated-partitions"));
assertEquals("", underReplicatedOutput,
String.format("--under-replicated-partitions shouldn't return anything: '%s'", underReplicatedOutput));
assertFalse(underReplicatedOutput.contains(testTopicNameLogLine),
String.format("--under-replicated-partitions shouldn't contain '%s': '%s'", testTopicNameLogLine, underReplicatedOutput));

int maxRetries = 20;
long pause = 100L;
Expand Down