MINOR: auto-topic creation back-off #20663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gemini review |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a back-off mechanism for auto-topic creation in the AutoTopicCreationManager to prevent excessive retry attempts on every heartbeat when topic creation fails.
- Filters out topics that have cached errors (back-off period) or are already in-flight
- Prevents redundant topic creation requests during error conditions
- Adds comprehensive unit tests to verify back-off behavior and inflight topic handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/src/main/scala/kafka/server/AutoTopicCreationManager.scala | Implements back-off logic by filtering topics with cached errors and inflight requests |
| core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala | Adds unit tests for back-off mechanism, expired errors, inflight topics, and interaction scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala
Outdated
Show resolved
Hide resolved
lucasbru
reviewed
Oct 9, 2025
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala
Outdated
Show resolved
Hide resolved
|
We seem to have problems with CI and Java 25. Can you try rebasing on latest trunk please? |
RaidenE1
force-pushed
the
topic-creation-backoff
branch
from
e4c3b28 to
319f835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-topic creation in
AutoTopicCreationManagercurrently retriescreating internal topics with every heartbeat.
A simple back-off mechanism was implemented: if there is error in the
errorcache and it's not expired or it's already in the inflight topics,
then not send the topic creation request.
Unit tests are added as well.
Reviewers: Lucas Brutschy [email protected]