KAFKA-19747: Update ClientTelemetryReporter telemetry push error handling #20661
+172
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbejeck
commented
Oct 8, 2025
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
Outdated
Show resolved
Hide resolved
bbejeck
commented
Oct 8, 2025
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
Outdated
Show resolved
Hide resolved
|
@apoorvmittal10 PTAL |
apoorvmittal10
approved these changes
Oct 8, 2025
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 8, 2025
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Oct 8, 2025
bbejeck
force-pushed
the
KAFKA-19747_improve_failed_push_handling
branch
from
839a65f to
026728b
Compare
…g between retryable and fatal exceptions and add test cases
bbejeck
force-pushed
the
KAFKA-19747_improve_failed_push_handling
branch
from
026728b to
900be01
Compare
|
@mjsax I've updated the logic for checking exceptions |
|
Merged #20661 into trunk |
bbejeck
added a commit
that referenced
this pull request
Oct 9, 2025
…ling (#20661) When a failure occurs with a push telemetry request, any exception is treated as fatal, increasing the time interval to `Integer.MAX_VALUE` effectively turning telemetry off. This PR updates the error handling to check if the exception is a transient one with expected recovery and keeps the telemetry interval value the same in those cases since a recovery is expected. Reviewers: Apoorv Mittal <[email protected]>, Matthias Sax<[email protected]>
bbejeck
added a commit
that referenced
this pull request
Oct 9, 2025
…ling (#20661) When a failure occurs with a push telemetry request, any exception is treated as fatal, increasing the time interval to `Integer.MAX_VALUE` effectively turning telemetry off. This PR updates the error handling to check if the exception is a transient one with expected recovery and keeps the telemetry interval value the same in those cases since a recovery is expected. Reviewers: Apoorv Mittal <[email protected]>, Matthias Sax<[email protected]>
|
cherry-picked to 4.1 aceb32d |
|
cherry-picked to 4.0 3243300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a failure occurs with a push telemetry request, any exception is
treated as fatal, increasing the time interval to
Integer.MAX_VALUEeffectively turning telemetry off. This PR updates the error handling
to check if the exception is a transient one with expected recovery and
keeps the telemetry interval value the same in those cases since a
recovery is expected.
Reviewers: Apoorv Mittal [email protected], Matthias
Sax[email protected]