-
Notifications
You must be signed in to change notification settings - Fork 14.7k
MINOR: ignore result of "missing build scan" #20659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
@Yunyung could you please revert previous failed approach? |
Sure. Revert the failed approach from #20644 in latest comimt. |
.github/workflows/ci-complete.yml
Outdated
description: 'Could not find build scan' | ||
context: Gradle Build Scan / ${{ env.status-context }} | ||
state: 'error' | ||
state: 'success' # WAR: Mark as successful, not show as failing, for those branches without the KAFKA-18748 patches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KAFKA-18748 is not the only reason. The other cause is the difference in supported JDKs. For example, trunk
now supports JDK 25, but the 4.1
branch does not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks.
@mumrah What do you think? I want to use a simple fix to eliminate the build errors on the 4.1 and 4.0 branches. We can discuss rewriting |
Workaround: Always mark the result of "missing build scan" as
successful, not as failing, for 4.0 and 4.1.
Two reasons causing missing build scan:
ci-complete
is inconsistent with otheractive branches, causing the build report task to fail.
The real solution will be in
KAFKA-19768.