MINOR: Followup KAFKA-18193 for null check and error message #20650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1a2st
force-pushed
the
MINOR-followup-KAFKA-18193
branch
from
72ecd6f to
e572ac8
Compare
m1a2st
force-pushed
the
MINOR-followup-KAFKA-18193
branch
from
e572ac8 to
c231f07
Compare
chia7712
reviewed
Oct 7, 2025
streams/src/main/java/org/apache/kafka/streams/CloseOptions.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Oct 8, 2025
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Oct 10, 2025
| final CloseOptionsInternal optionsInternal = new CloseOptionsInternal(options); | ||
| final String msgPrefix = prepareMillisCheckFailMsgPrefix(optionsInternal.timeout(), "timeout"); | ||
| final long timeoutMs = validateMillisecondDuration(optionsInternal.timeout().get(), msgPrefix); | ||
| final Duration timeout = optionsInternal.timeout().orElseGet(() -> Duration.ofMillis(Long.MAX_VALUE)); |
There was a problem hiding this comment.
could you please add test for empty timeout?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to KAFKA-18193. It addresses the need for a null
check and an improved error message. Please refer to the previous
comments and the review of
#19955 (review)
for more context.
Reviewers: Chia-Ping Tsai [email protected]