KAFKA-18710: Move DynamicClientQuotaPublisher to metadata module #20642
+105
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
|
I think that |
chia7712
reviewed
Oct 13, 2025
| /** | ||
| * Interface for updating client quotas based on metadata changes. | ||
| */ | ||
| public interface ClientQuotaUpdater { |
There was a problem hiding this comment.
Could it be replaced by Consumer<ClientQuotasDelta>?
|
|
||
| @Override | ||
| public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage, LoaderManifest manifest) { | ||
| String deltaName = "MetadataDelta up to " + newImage.highestOffsetAndEpoch().offset(); |
There was a problem hiding this comment.
would you mind initializing it lazily?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves yet another publisher to the metadata module. Fixes [1].
[1] - https://issues.apache.org/jira/browse/KAFKA-18710