KAFKA-19091: Fix race condition in DelayedFutureTest #19553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
One question from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root case of flakiness is race condition between worker thread (thread which is executing the test) and executor-testDelayedFuture (thread which should execute callback).
It was fixed with TestUtils#waitForCondition to wait until callback will be done
Test evidence:
Test was running 1000 times with repeated test.
Results:
~/p/kafka (bloku/kafka-19091) [1]> ./gradlew server:test --tests DelayedFutureTest --fail-fast > res.txt~/p/kafka (bloku/kafka-19091)> grep FAILED res.txt~/p/kafka (bloku/kafka-19091) [1]>res.txt:
> Task :server:testGradle Test Run :server:test > Gradle Test Executor 14 > DelayedFutureTest > testDelayedFuture() > repetition 1 of 1000 PASSED...
BUILD SUCCESSFUL in 37m