MINOR: support ipv6 in ducker-ak #19537
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
kirktrue
reviewed
Apr 23, 2025
tests/docker/ducker-ak
Outdated
| @@ -83,6 +83,8 @@ up [-n|--num-nodes NUM_NODES] [-f|--force] [docker-image] | |||
| on the host. The argument can be a single port (like 5005), a port range like (5005-5009) | |||
| or a combination of port/port-range separated by comma (like 2181,9092 or 2181,5005-5008). | |||
| By default no port is exposed. See README.md for more detail on this option. | |||
|
|
|||
| If --ipv6 is specified, we will create a docker network with IPv6 enabled. | |||
There was a problem hiding this comment.
Super nitpicky...
Suggested change
| If --ipv6 is specified, we will create a docker network with IPv6 enabled. | |
| If --ipv6 is specified, we will create a Docker network with IPv6 enabled. |
tests/docker/ducker-ak
Outdated
| [[ $? -ne 0 ]] && die "failed to find the /etc/hosts entry for ${node}" | ||
| done | ||
| exec 3>&- | ||
| for n in $(seq -f %02g 1 ${num_nodes}); do | ||
| local node="ducker${n}" | ||
| docker exec --user=root "${node}" \ | ||
| bash -c "grep -v ${node} /opt/kafka-dev/tests/docker/build/node_hosts >> /etc/hosts" | ||
| # Filter oud ipv4 addresses if ipv6 |
There was a problem hiding this comment.
Suggested change
| # Filter oud ipv4 addresses if ipv6 | |
| # Filter out ipv4 addresses if ipv6 |
| must_do -v docker network create ducknet | ||
| network_create_args="" | ||
| if [[ "${ipv6}" == "true" ]]; then | ||
| subnet_cidr_prefix="${DUCKER_SUBNET_CIDR:-"fc00:cf17"}" |
There was a problem hiding this comment.
I'm not knowledgeable about IPv6, so I'm wondering if this is a safe thing to hardcode?
imcdo
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ipv6 support to
ducker-ak