RandomDate: include end date and handle single-day ranges #6610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RandomDate now picks inclusive date ranges by delegating the day selection to a new
pickRandomDay(...)helper. That method returns the single-day range immediately and otherwise callsThreadLocalRandom.nextLong(start, end + 1)usingMath.incrementExact, so the configured end date can be emitted andstart == endno longer throws. The tests for__RandomDatewere updated to accept both bounds and now include explicit coverage for the single-day case and for ensuring the end date eventually appears.Motivation and Context
Fixes #6609 . The current implementation treats the end date as exclusive and blows up when both bounds are equal, which makes it impossible to configure fixed dates or truly closed intervals in test plans.
How Has This Been Tested?
./gradlew :src:functions:test --tests org.apache.jmeter.functions.TestTimeRandomDateFunction./gradlew check(fails in:src:protocol:bolt:testdue to the flakyBoltSamplerTest.should ignore invalid timeout values()timeout; unrelated to this change)
Screenshots (if appropriate):
n/a
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
My code follows the code style of this project.
I have updated the documentation accordingly.