Skip to content

Conversation

chihyu0917
Copy link

Description

I report the problem in the issue #16593

Solutions

  1. Walk the subtree instead instead of pinning to indices. Added helper containsNodeType(PlanNode, Class<?>) that recursively checks for a given node class.
  2. Accept either DeviceViewNode or SingleDeviceViewNode. Assertions now allow both legitimate alternatives.
  3. Reused the helper across all four tests, so they tolerate harmless structural differences and stay reliable under random seeds shuffling.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.

@chihyu0917 chihyu0917 changed the title Fix Bugs in AlignByDeviceOrderByLimitOffsetTest [IOTDB-6357] Fix Bugs in AlignByDeviceOrderByLimitOffsetTest Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant