fix test in AggregationDistributionTest #16566
Open
+48
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Non-Deterministic Behavior in AggregationDistributionTest
Problem
The test
testAggregationWithMultiGroupByLevelNode
was failing non-deterministically under NonDex with a 40% failure rate due to order-dependent fragment access.Way to Reproduce
Root Cause
The test accessed fragment instances by fixed array indices (
get(0)
,get(1)
), assuming they would always appear in a specific order:When NonDex shuffled collection iteration order during distributed query planning, fragment instances appeared in different orders, causing the test to fail even though the query plan was semantically correct.
Solution
Made the test order-independent by iterating through all fragments and pattern-matching against expected descriptors instead of accessing by index:
Added helper method
matchesExpectedDescriptor()
to check if aGroupByLevelNode
matches expected descriptor patterns using set-based comparison.This PR has:
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR