fix tests in ClusterSchemaTreeTest #16538
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Non-Deterministic Behavior in ClusterSchemaTreeTest
Problem
Five tests in
ClusterSchemaTreeTest
were failing non-deterministically under NonDex due to reliance on collection iteration order:testAppendMeasurementPath
testMergeSchemaTree
testMultiWildcard
testSchemaTreeVisitor
testSchemaTreeWithScope
Way to Reproduce
Root Cause
Tests used order-dependent array comparisons combined with
limit
/offset
parameters on non-deterministically ordered collections (ConcurrentHashMap
).Solution
checkVisitorResult
methods to useHashSet
comparison instead of index-based array comparisonlimit=X, offset=Y
tolimit=0, offset=0
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR