Skip to content
This repository was archived by the owner on Jun 3, 2021. It is now read-only.

Conversation

@KorolZhu
Copy link
Contributor

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Sep 29, 2018

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

Copy link
Member

@wqyfavor wqyfavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update apache/master so that project file will not be modified.

@KorolZhu
Copy link
Contributor Author

image

iOS sdk project build failed.

# Conflicts:
#	ios/sdk/WeexSDK.xcodeproj/project.pbxproj
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to master branch, as there is a conflict.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants