feat: add func invoker #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Dec 18, 2024
|
|
||
| type FuncInvoker struct { | ||
| services map[string]FuncService | ||
| ServicesMapLock sync.Mutex |
There was a problem hiding this comment.
Put the lock on its guard object
There was a problem hiding this comment.
我是说把 lock 放在 map 上面，你这还是在 map 下面哦
There was a problem hiding this comment.
哦 我之前理解错了 已修正
|
Can this invoker match err to retry? |
support retry now |
AlexStocks
reviewed
Dec 19, 2024
| @@ -191,22 +191,19 @@ func (f *FuncServiceImpl) needRetry(impl *state.ServiceTaskStateImpl, countMap m | |||
| return false | |||
| } | |||
|
|
|||
| currentInterval := f.calculateRetryInterval(retry, attempt) | |||
| interval := retry.IntervalSecond() | |||
| backoffRate := retry.BackoffRate() | |||
There was a problem hiding this comment.
line 195 以下这块代码可以精简为：
backoffRate := retry.BackoffRate()
curInterval := int64(interval * 1000)
if attempt {
curInterval = int64(interval * backoffRate * float64(attempt) * 1000)
}
|
luky116
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR supports local method calls (including methods within structs).
Which issue(s) this PR fixes:
Fixes #729
Special notes for your reviewer:
Does this PR introduce a user-facing change?: