bugfix: error image when use null value as image query condition in insert on duplicate #704 #725
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| if len(paramMap) == 0 || len(metaData.Indexs) == 0 { | ||
| return "", nil, nil | ||
| } | ||
| hasPK := false |
There was a problem hiding this comment.
use
gotogoto 不太好理解？
那这里还需要改为goto吗
|
|
||
| // Reset primary keys map | ||
| u.BeforeImageSqlPrimaryKeys = make(map[string]bool) | ||
|
|
||
| pkIndexMap := u.getPkIndex(insertStmt, metaData) | ||
| var pkIndexArray []int |
| for i := 0; i < len(insertRows); i++ { | ||
| var rowConditions []string | ||
| var rowArgs []driver.Value | ||
| usedParams := make(map[string]bool) |
|
把单测也加上 |
| // Test case for null unique index | ||
| { | ||
| execCtx: &types.ExecContext{ | ||
| Query: "insert into t_unique(id, a, b) values(1, NULL, 2) on duplicate key update b = 5", |
| { | ||
| execCtx: &types.ExecContext{ | ||
| Query: "insert into t_unique(id, a, b) values(1, NULL, 2) on duplicate key update b = 5", | ||
| MetaDataMap: map[string]types.TableMeta{"t_unique": tableMeta1}, |
There was a problem hiding this comment.
MetaDataMap 会在后面使用，确保这个 key 被用到，可以 debug 看看是否走到了你预想的步骤
| { | ||
| execCtx: &types.ExecContext{ | ||
| Query: "insert into t_unique(id, b) values(NULL, 2) on duplicate key update b = 5", | ||
| MetaDataMap: map[string]types.TableMeta{"t_unique": tableMeta1}, |
|
单纯从语义来看，这样会导致出问题。如果他的联合索引是 "id", "name", "age"，那么他生成的 SELECT SQL 也应该包含这三字段，如果使用其中部分字段，生成的 SELECT 没办法保证获取数据的唯一性
|
|
What this PR does:
This PR addresses the SQL generation and parameter handling issues in the MySQL Insert On Duplicate Key Update undo log builder. It improves the handling of primary key conditions, parameter type safety, and fixes spacing issues in SQL generation.
Which issue(s) this PR fixes:
Fixes #704
Special notes for your reviewer:
Through these improvements, I aim to provide a more robust and efficient solution to meet the project's development needs. If you encounter any issues with the refactoring, please feel free to contact me.
Does this PR introduce a user-facing change?: