chore: switch CI jobs to use ubuntu-slim instead of ubuntu-latest#902
chore: switch CI jobs to use ubuntu-slim instead of ubuntu-latest#902yangxk1 merged 2 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to use the new ubuntu-slim runner for lightweight CI jobs, and adjusts the license-check workflow to use Apache’s license header checking tooling/config.
Changes:
- Switch selected workflow jobs from
ubuntu-latesttoubuntu-slim. - Revise the license workflow job (rename job, improve checkout inputs for push/PR contexts).
- Replace the previous license header checker with
apache/skywalking-eyesand add.github/.licenserc.yamlconfiguration.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/pr-title.yml | Uses ubuntu-slim for the PR title validation job. |
| .github/workflows/license.yml | Uses ubuntu-slim, adjusts checkout defaults, switches license checker to SkyWalking Eyes with config. |
| .github/workflows/docs.yml | Uses ubuntu-slim for docs site build job. |
| .github/.licenserc.yaml | Adds license header checking configuration for the license workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Check license header | ||
| uses: apache/skywalking-eyes@main | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: |
There was a problem hiding this comment.
apache/skywalking-eyes is referenced from the moving @main branch, which makes the workflow non-reproducible and increases supply-chain risk. Pin this action to a tagged release or a specific commit SHA instead.
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the |
There was a problem hiding this comment.
This new .github/.licenserc.yaml file is missing the standard ASF license header comment block that the repository uses for YAML files. Add the ASF header to the top of this file (or ensure it’s explicitly excluded by the license-check config) so the license check and ASF policy remain consistent.
.github/workflows/license.yml
Outdated
| - name: Check License Header | ||
| uses: korandoru/hawkeye@v4 | ||
| - name: Check license header | ||
| uses: apache/skywalking-eyes@main |
There was a problem hiding this comment.
noticed that the usage displayed on the GitHub readme is
uses: apache/skywalking-eyes/header@main # always prefer to use a revision instead of `main`.
|
I have updated the code. |
Reason for this PR
This PR aims to use ubuntu-slim for GitHub Actions.
ubuntu-slim is a new cost-efficient runner to fit small jobs like license-check. We had better use this to save ASF infra usage (if possible)
fix: #901
.licenserc.yml referred to iceberg-cpp
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?