Skip to content

feat(java): Add DATE and TIMESTAMP support to DataType enum #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yangxk1 merged 2 commits into from
Dec 29, 2025
Merged

feat(java): Add DATE and TIMESTAMP support to DataType enum #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
200a18e
Add DATE and TIMESTAMP support to DataType enum
shivendra-dev54 Dec 17, 2025
21a8c7f
added tests for newly added data types
shivendra-dev54 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion maven-projects/info/src/main/java/org/apache/graphar/info/type/DataType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,13 @@ public enum DataType {
STRING,

/** List of same type */
LIST;
LIST,

/** Date value */
DATE,

/** Timestamp value */
TIMESTAMP;

public static DataType fromString(String s) {
switch (s) {
Expand All @@ -57,6 +63,10 @@ public static DataType fromString(String s) {
return STRING;
case "list":
return LIST;
case "date":
return DATE;
case "timestamp":
return TIMESTAMP;
default:
throw new IllegalArgumentException("Unknown data type: " + s);
}
Expand Down
11 changes: 11 additions & 0 deletions maven-projects/info/src/test/java/org/apache/graphar/info/PropertyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,17 @@ public void testPropertyWithAllDataTypes() {
Property listProp = TestDataFactory.createProperty("items", DataType.LIST, false, true);
Assert.assertEquals(DataType.LIST, listProp.getDataType());
TestVerificationUtils.verifyProperty(listProp, "items", false, true);

// Newly added data types
Property dateProp =
TestDataFactory.createProperty("creationDate", DataType.DATE, false, true);
Assert.assertEquals(DataType.DATE, dateProp.getDataType());
TestVerificationUtils.verifyProperty(dateProp, "creationDate", false, true);

Property timestampProp =
TestDataFactory.createProperty("createdAt", DataType.TIMESTAMP, false, true);
Assert.assertEquals(DataType.TIMESTAMP, timestampProp.getDataType());
TestVerificationUtils.verifyProperty(timestampProp, "createdAt", false, true);
}

@Test
Expand Down