Skip to content

Truncate name of timeline records to fit into database field #8372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

jmezach
Copy link
Contributor

@jmezach jmezach commented Apr 2, 2025

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • [N/A] I have added relevant tests.
  • [N/A] I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

This simply truncates the name of an Azure DevOps timeline record so that it fits into the underlying database table. Since these names aren't used anywhere else we believe it is fine to just truncate it.

Does this close any open issues?

Closes #8325

Screenshots

N/A

Other Information

See discussion in #8325 for details.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug labels Apr 2, 2025
@klesh
Copy link
Contributor

klesh commented Apr 8, 2025

Thanks for the PR.
Seems like it would fail when the name is shorter than 255, please fix it before I can merge.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 8, 2025
@jmezach
Copy link
Contributor Author

jmezach commented Apr 8, 2025

@klesh Ah, yes of course. Sorry about that, pretty new at Go as a programming language. I believe I've fixed it now though ;)

@klesh
Copy link
Contributor

klesh commented Apr 8, 2025

Thanks for your contribution.

@klesh klesh merged commit 0ecfbb0 into apache:main Apr 8, 2025
10 of 11 checks passed
@jmezach jmezach deleted the feature/expand-timelinerecords-name branch April 8, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Azure DevOps Go] Error in extractApiTimelineRecords Data too long for column 'name'
2 participants