-
Notifications
You must be signed in to change notification settings - Fork 578
fix: Consider first comment to be of type Review #8332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Don't see any specific related tests to this function or classes. Are these to be considered part of the csv testing within dataflow ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
It seems that only the Github plugin respects this
|
f64c510
to
9ca42b7
Compare
Hi, @tcarac e2e tests is failing, I think the csv files located in https://github.com/apache/incubator-devlake/tree/main/backend/plugins/dora/e2e/change_lead_time need to be updated, try adding |
@klesh This is done. Please lmk if we need anything else and TY for your support in this. |
Thanks for updating the files. and seems like the e2e-tests are still failing on PG database, not sure why though, maybe the column is NULL instead of empty? |
pr-type/bug-fix
,pr-type/feature-development
, etc.Summary
Takes into a account Pr Type to determine if it should be considered as the first Pr in pickup time
Does this close any open issues?
#8317
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.