-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zentao): make sure connection uncacheable #8245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Dec 18, 2024
klesh
approved these changes
Dec 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* fix(zentao): make sure connection uncacheable * fix(zentao): fix lint errors * Revert "fix(zentao): fix lint errors" This reverts commit e216a23. * fix(zentao): fix lint errors * fix(zentao): remove UnCacheableConnetion interface, try to fix it with another way
🤖 Target: #release-v1.0 cherry pick finished successfully 🎉! |
github-actions
bot
added
the
bot/auto-cherry-pick-completed
auto cherry pick completed
label
Dec 18, 2024
d4x1
added a commit
that referenced
this pull request
Dec 18, 2024
* fix(zentao): make sure connection uncacheable * fix(zentao): fix lint errors * Revert "fix(zentao): fix lint errors" This reverts commit e216a23. * fix(zentao): fix lint errors * fix(zentao): remove UnCacheableConnetion interface, try to fix it with another way Co-authored-by: Lynwee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot/auto-cherry-pick-completed
auto cherry pick completed
component/plugins
This issue or PR relates to plugins
needs-cherrypick-v1.0
pr-type/bug-fix
This PR fixes a bug
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix
,pr-type/feature-development
, etc.Summary
What does this PR do?
According to https://www.zentao.net/book/api/664.html#6, zentao's token will expire after 24 min. If users try to list scopes after 24 min, the api client will get a response with http status code 401.
This PR just makes sure zentao connections uncacheable.
Does this close any open issues?
Closes N/A
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.