Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): update Makefile to include version prefix in go-dep command #8194

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(backend): update Makefile to include version prefix in go-dep command #8194

merged 1 commit into from
Nov 19, 2024

Conversation

rodrigoluizs
Copy link
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

Fixes the issue in the go-dep make command where the version prefix was missing, ensuring consistent dependency installation.

How to Reproduce?

cd backend
make go-dep                                                                        
go install github.com/vektra/mockery/[email protected]
go: github.com/vektra/mockery/[email protected]: github.com/vektra/mockery/[email protected]: invalid version: unknown revision 2.43.0
make: *** [go-dep] Error 1

@rodrigoluizs
fix(backend): update Makefile to include version prefix in go-dep com…
128bb59 
…mand

The go-dep make command was missing a version prefix, causing a dependency resolution issue. This change fixes the command to use the correct version prefix.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident labels Nov 18, 2024
@klesh klesh merged commit 840f698 into apache:main Nov 19, 2024
10 checks passed
@klesh
Copy link
Contributor

klesh commented Nov 19, 2024

Thanks for your contribution.
Would you like to submit another PR to the release-v1.0 branch so is can be released faster?

@rodrigoluizs
Copy link
Contributor Author

of course, I'll do it.

@rodrigoluizs rodrigoluizs deleted the rodrigoluizs/fix-backend-go-dep-command branch November 19, 2024 07:11
@rodrigoluizs
Copy link
Contributor Author

@klesh
here we go: #8197

@klesh
Copy link
Contributor

klesh commented Nov 22, 2024

Nice, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigoluizs @klesh